Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
This PR adds
result
combinators toQCheck
as anarbitrary
QCheck.{Gen,Print,Shrink,Observable}
, andQCheck2.{Gen,Print,Observable}
.Shrinking-wise they just reduce within
Ok _
andError _
without attempting to reduce one to the other.Edit:
Ratio-wise, I've gone with 75% in favor of generating
Ok _
- compared tooption
's 85% preference forSome _
,from the rationale that
Ok _
is the preferred and expected path/value, but with a greater chance ofError _
since its constructor is more expressive thanNone
and hence should be exercised more.