Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define getTitle method on Settings pages to use localised name #224

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

danjohnson95
Copy link
Contributor

Fixes #221, see comment #221 (comment)

@jbrooksuk
Copy link
Member

@danjohnson95 thoughts on creating an abstract BaseResource where we can share this common logic?

@danjohnson95
Copy link
Contributor Author

Nice idea! Done

@jbrooksuk jbrooksuk merged commit c443938 into cachethq:main Jan 28, 2025
25 checks passed
@jbrooksuk
Copy link
Member

Legend!

@danjohnson95 danjohnson95 deleted the fix-221 branch January 28, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation point is not used as title for setting
2 participants