Implementing metrics into the status page #58
Conversation
|
Btw I have some questions on how/when the calculation (avg, sum) should be performed. I guess in |
| <div class="flex flex-col gap-8"> | ||
| @foreach($metrics as $metric) | ||
| <x-cachet::metric :metric="$metric" /> | ||
| <x-cachet::metric :metric="$metric" /> |
There was a problem hiding this comment.
It looks like this duplication can be removed?
| <x-cachet::metric :metric="$metric" /> |
There was a problem hiding this comment.
For the moment, I keep it for debugging purposes (by default, we only have one metric. It allows testing the individual component with two different instances.)
|
@Ionys320 how's this going? :) |
|
Hi @jbrooksuk! I would need to know how the avg/sum must be made, and where. I don't really know how this part of the feature is working. And after this, I don't know if something would be missing, let me know! |
|
I'd take inspiration from the current code in v2.4 (https://github.com/cachethq/cachet/blob/2.4/app/Repositories/Metric/MySqlRepository.php). |
The "problem" is that, actually, ChartJS displays the whole dataset. For example, if I ask the data of the last 30 days, I'll have each point created for the metric X of the last 30 days. I see that the previous code is making a May I ask you to check this part? It will probably be simplier. Thanks! |
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: James Brooks <[email protected]>
|
@Ionys320 I've rebased this onto the latest version of main and updated some styling of the charts. |
|
@Ionys320 how would you feel about utilizing Filament's own stats component here, like we do for the dashboard? Would that simplify anything? |
This is a WIP but allows you to monitor the changes related to issue #56.
This feature is actively using Alpine. Maybe some parts could be improved to use Laravel in a better way (for example, avoid using
<?php echo json_encode($metric); ?>in the code).No issue is currently know.
Please note that for debugging purposes, each metric is displayed twice. The reason is that by default, we only have one metric. It allows testing the individual component with two different instances.
Screen of the current version:
