Removed newline characters from precomputed etags

caddyserver · Jun 13, 2024 · 4d3a752 · 4d3a752
1 parent 8e0d3e1
commit 4d3a752
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/modules/caddyhttp/fileserver/staticfiles.go b/modules/caddyhttp/fileserver/staticfiles.go
@@ -690,7 +690,12 @@ func (fsrv *FileServer) getEtagFromFile(fileSystem fs.FS, filename string) (stri
 		if err != nil {
 			return "", fmt.Errorf("cannot read etag from file %s: %v", etagFilename, err)
 		}
-		return string(etag), nil
+		etagStr := string(etag)
+
+		// Etags should not contain newline characters
+		etagStr = strings.ReplaceAll(etagStr, "\n", "")
+
+		return etagStr, nil
 	}
 	return "", nil
 }