Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't exit early on error in remote CI machine #6519

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

mohammed90
Copy link
Member

GitHub Actions shell scripts are loaded with set -e, which tells the shell to exit at any error. The impact on our flow is missing the deletion step of the code for every failed CI run on the remote machine. This PR fixes it so No Files Left Behind.

@mohammed90 mohammed90 added the CI/CD 🔩 Automated tests, releases label Aug 15, 2024
@mholt
Copy link
Member

mholt commented Aug 15, 2024

Ah, so this'll help prevent disk space depletion? Or if these are ephemeral instances do we need to do the cleanup?

@mohammed90
Copy link
Member Author

Ah, so this'll help prevent disk space depletion?

Yep, but it's just a copy of the repo at the subject commit, not that much.

Or if these are ephemeral instances do we need to do the cleanup?

It isn't an ephemeral machine. It's the IBM machine.

@dunglas
Copy link
Collaborator

dunglas commented Aug 18, 2024

Maybe should this be done only on IBM machines to prevent running useless steps on ephemeral containers in other cases?

@mohammed90
Copy link
Member Author

Maybe should this be done only on IBM machines to prevent running useless steps on ephemeral containers in other cases?

It is only on the IBM machine. It's in the s390x-test job. That job only runs on a specific machine.

@mohammed90 mohammed90 merged commit 043fe41 into master Aug 18, 2024
22 of 23 checks passed
@mohammed90 mohammed90 deleted the no-bail-on-error branch August 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants