-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #20
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,41 @@ | ||
| module github.com/caddyserver/ingress | ||
|
|
||
| go 1.12 | ||
| go 1.13 | ||
|
|
||
| require ( | ||
| github.com/caddyserver/caddy/v2 v2.0.0-beta6 | ||
| github.com/docker/distribution v2.7.1+incompatible // indirect | ||
| github.com/mholt/certmagic v0.7.5 | ||
| github.com/opencontainers/go-digest v1.0.0-rc1 // indirect | ||
| github.com/caddyserver/caddy/v2 v2.0.0-beta11 | ||
| github.com/mholt/certmagic v0.9.0 | ||
| github.com/pkg/errors v0.8.1 | ||
| github.com/prometheus/client_golang v1.1.0 | ||
| github.com/sirupsen/logrus v1.4.2 | ||
| gopkg.in/go-playground/assert.v1 v1.2.1 // indirect | ||
| gopkg.in/go-playground/pool.v3 v3.1.1 | ||
| k8s.io/api v0.0.0-20190602125759-c1e9adbde704 | ||
| k8s.io/apiextensions-apiserver v0.0.0-20190602131520-451a9c13a3c8 // indirect | ||
| k8s.io/apimachinery v0.0.0-20190602125621-c0632ccbde11 | ||
| k8s.io/client-go v0.0.0-20190602130007-e65ca70987a6 | ||
| k8s.io/cloud-provider v0.0.0-20190503112208-4f570a5e5694 // indirect | ||
| k8s.io/kubernetes v1.14.1 | ||
| k8s.io/utils v0.0.0-20190506122338-8fab8cb257d5 // indirect | ||
| k8s.io/api v0.17.0 | ||
| k8s.io/apimachinery v0.17.0 | ||
| k8s.io/client-go v0.17.0 | ||
| k8s.io/kubernetes v1.17.0 | ||
| ) | ||
|
|
||
| replace ( | ||
| k8s.io/api => k8s.io/api v0.17.0 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.17.0 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.17.0 | ||
| k8s.io/apiserver => k8s.io/apiserver v0.17.0 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.17.0 | ||
| k8s.io/client-go => k8s.io/client-go v0.17.0 | ||
| k8s.io/cloud-provider => k8s.io/cloud-provider v0.17.0 | ||
| k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.17.0 | ||
| k8s.io/code-generator => k8s.io/code-generator v0.17.0 | ||
| k8s.io/component-base => k8s.io/component-base v0.17.0 | ||
| k8s.io/cri-api => k8s.io/cri-api v0.17.0 | ||
| k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.17.0 | ||
| k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.17.0 | ||
| k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.17.0 | ||
| k8s.io/kube-proxy => k8s.io/kube-proxy v0.17.0 | ||
| k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.17.0 | ||
| k8s.io/kubectl => k8s.io/kubectl v0.17.0 | ||
| k8s.io/kubelet => k8s.io/kubelet v0.17.0 | ||
| k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.17.0 | ||
| k8s.io/metrics => k8s.io/metrics v0.17.0 | ||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.17.0 | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand why these are necessary? I looked at the linked issues but there's a lot going on in those 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mholt do you mean the
replacesection? Since K8s is moving from an outdated dependency system to go mod and they are using a single repo (that should have a single tag) but at the same time they chose to use a 0.x.y version of go mods (see kubernetes/kubernetes#84608 (comment) ) we need to explain dependencies that are reported asv0.0.0in thekubernetes/kubernetesrepo (since at the moment the reference are not updated for each release).I don't have a background that allow me to go deep on explanation, you can find a lot of info on SIG-ARCHITECTURE https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md
Other project follow the same approach (see -for example- https://github.com/kubernetes/ingress-nginx/blob/master/go.mod#L58-L81 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh... that is really unusual. So this is a temporary thing, it sounds like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mholt I hope too, but sincerely I have no idea on schedule / improvement for next releases on this side...