sync idl files from server #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancexu
approved these changes
Dec 12, 2017
| * created for the workflow so new decisions could be made. Similar to RespondActivityTaskCompleted but use DomainID, | ||
| * WorkflowID and ActivityID instead of 'taskToken' for completion. It fails with 'EntityNotExistsError' | ||
| * if the these IDs are not valid anymore due to activity timeout. | ||
| * created for the workflow so new decisions could be made. Use the 'taskToken' provided as response of |
There was a problem hiding this comment.
These comments shouldn't be changed like this.
Sorry it was my bad, I forget to change the service side to be same as client. Will do
There was a problem hiding this comment.
Please use cadence-workflow/cadence#457 comments for these 3 methods endwith ByID
yiminc-zz
force-pushed
the
sync_idl_files
branch
from
36a8b33 to
6c57f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to work on fail decision task when decider panics and realize there are some accumulated IDL changes on server that has not been propagate to client side. This PR copies the 2 idl files from server to client, no other changes included.