Convert task store/manager to use internal types (#3663)

#3612
cadence-workflow · Oct 16, 2020 · 39dfa44 · 39dfa44
1 parent aa81104
commit 39dfa44
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/common/persistence/cassandra/cassandraTaskPersistence.go b/common/persistence/cassandra/cassandraTaskPersistence.go
@@ -416,8 +416,8 @@ func (d *cassandraTaskPersistence) CreateTasks(
 				rowTypeTask,
 				task.TaskID,
 				domainID,
-				task.Execution.GetWorkflowId(),
-				task.Execution.GetRunId(),
+				task.Execution.GetWorkflowID(),
+				task.Execution.GetRunID(),
 				scheduleID,
 				cqlNowTimestamp)
 		} else {
@@ -431,8 +431,8 @@ func (d *cassandraTaskPersistence) CreateTasks(
 				rowTypeTask,
 				task.TaskID,
 				domainID,
-				task.Execution.GetWorkflowId(),
-				task.Execution.GetRunId(),
+				task.Execution.GetWorkflowID(),
+				task.Execution.GetRunID(),
 				scheduleID,
 				cqlNowTimestamp,
 				ttl)

diff --git a/common/persistence/persistenceInterface.go b/common/persistence/persistenceInterface.go
@@ -853,7 +853,7 @@ type (
 
 	// InternalCreateTasksInfo describes a task to be created in InternalCreateTasksRequest
 	InternalCreateTasksInfo struct {
-		Execution workflow.WorkflowExecution
+		Execution types.WorkflowExecution
 		Data      *InternalTaskInfo
 		TaskID    int64
 	}

diff --git a/common/persistence/taskManager.go b/common/persistence/taskManager.go
@@ -24,6 +24,8 @@ package persistence
 
 import (
 	"context"
+
+	"github.com/uber/cadence/common/types/mapper/thrift"
 )
 
 type (
@@ -108,7 +110,7 @@ func (t *taskManager) toInternalCreateTaskInfo(createTaskInfo *CreateTaskInfo) *
 		return nil
 	}
 	return &InternalCreateTasksInfo{
-		Execution: createTaskInfo.Execution,
+		Execution: *thrift.ToWorkflowExecution(&createTaskInfo.Execution),
 		Data:      t.toInternalTaskInfo(createTaskInfo.Data),
 		TaskID:    createTaskInfo.TaskID,
 	}