get rid of otherInfo

cadence-workflow · Jun 4, 2018 · 7c3c6ae · 7c3c6ae
1 parent 6f08661
commit 7c3c6ae
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 91 deletions.
diff --git a/.gen/go/admin/idl.go b/.gen/go/admin/idl.go
diff --git a/.gen/go/admin/types.go b/.gen/go/admin/types.go
diff --git a/.gen/go/history/idl.go b/.gen/go/history/idl.go
diff --git a/.gen/go/history/types.go b/.gen/go/history/types.go
diff --git a/idl/github.com/uber/cadence/admin.thrift b/idl/github.com/uber/cadence/admin.thrift
@@ -46,7 +46,6 @@ struct InquireWorkflowExecutionRequest {
 struct InquireWorkflowExecutionResponse{
   10: optional string shardId
   20: optional string historyAddr
-  30: optional string otherInfo
   40: optional string mutableStateInCache
   50: optional string mutableStateInDatabase
 }
diff --git a/idl/github.com/uber/cadence/history.thrift b/idl/github.com/uber/cadence/history.thrift
@@ -50,7 +50,6 @@ struct InquireMutableStateRequest{
 }
 
 struct InquireMutableStateResponse{
-  10: optional string otherInfo
   30: optional string mutableStateInCache
   40: optional string mutableStateInDatabase
 }

diff --git a/service/frontend/adminHandler.go b/service/frontend/adminHandler.go
@@ -100,7 +100,6 @@ func (adh *AdminHandler) InquireWorkflowExecution(ctx context.Context, request *
 	return &admin.InquireWorkflowExecutionResponse{
 		ShardId:                common.StringPtr(shardIDForOutput),
 		HistoryAddr:            common.StringPtr(historyAddr),
-		OtherInfo:              resp.OtherInfo,
 		MutableStateInDatabase: resp.MutableStateInDatabase,
 		MutableStateInCache:    resp.MutableStateInCache,
 	}, err

diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -555,14 +555,6 @@ func (e *historyEngineImpl) InquireMutableState(ctx context.Context,
 	if cacheHit && cacheCtx.msBuilder != nil {
 		msb := cacheCtx.msBuilder
 		retResp.MutableStateInCache, retError = e.toMutableStateJSON(msb)
-		otherInfo := ""
-		if len(msb.updateActivityInfos) > 0 {
-			otherInfo += "updateActivityInfos is not empty;"
-		}
-		if len(msb.deleteActivityInfos) > 0 {
-			otherInfo += "deleteActivityInfos is not empty;"
-		}
-		retResp.OtherInfo = &otherInfo
 	}
 
 	msb, retError := dbCtx.loadWorkflowExecution()