Add log in frontend API for InternalServiceError (#548)

* Add log in frontend API for InternalServiceError * Use TagErr instead
cadence-workflow · Feb 10, 2018 · 86e5954 · 86e5954
1 parent 083cb3c
commit 86e5954
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/common/logging/helpers.go b/common/logging/helpers.go
@@ -64,6 +64,20 @@ func LogOperationPanicEvent(logger bark.Logger, msg string, err error) {
 	}).Fatalf("%v.  Error: %v", msg, err)
 }
 
+// LogInternalServiceError is used to log internal service error
+func LogInternalServiceError(logger bark.Logger, err error) {
+	logger.WithFields(bark.Fields{
+		TagErr: err,
+	}).Error("Internal service error")
+}
+
+// LogUncategorizedError is used to log error that are uncategorized
+func LogUncategorizedError(logger bark.Logger, err error) {
+	logger.WithFields(bark.Fields{
+		TagErr: err,
+	}).Error("Uncategorized error")
+}
+
 //
 // History service logging methods
 //

diff --git a/service/frontend/handler.go b/service/frontend/handler.go
@@ -1678,6 +1678,7 @@ func (wh *WorkflowHandler) startRequestProfile(scope int) tally.Stopwatch {
 func (wh *WorkflowHandler) error(err error, scope int) error {
 	switch err.(type) {
 	case *gen.InternalServiceError:
+		logging.LogInternalServiceError(wh.Service.GetLogger(), err)
 		wh.metricsClient.IncCounter(scope, metrics.CadenceFailures)
 		return err
 	case *gen.BadRequestError:
@@ -1702,6 +1703,7 @@ func (wh *WorkflowHandler) error(err error, scope int) error {
 		wh.metricsClient.IncCounter(scope, metrics.CadenceErrQueryFailedCounter)
 		return err
 	default:
+		logging.LogUncategorizedError(wh.Service.GetLogger(), err)
 		wh.metricsClient.IncCounter(scope, metrics.CadenceFailures)
 		return &gen.InternalServiceError{Message: err.Error()}
 	}