address comments

cadence-workflow · Dec 22, 2017 · cba2a41 · cba2a41
1 parent d80a4d0
commit cba2a41
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/common/persistence/cassandraPersistence.go b/common/persistence/cassandraPersistence.go
@@ -888,7 +888,7 @@ func (d *cassandraPersistence) CreateWorkflowExecutionWithinBatch(request *Creat
 		request.ExecutionContext,
 		WorkflowStateCreated,
 		WorkflowCloseStatusNone,
-		request.LastFirstEventID,
+		common.FirstEventID,
 		request.NextEventID,
 		request.LastProcessedEvent,
 		cqlNowTimestamp,

diff --git a/common/persistence/cassandraPersistence_test.go b/common/persistence/cassandraPersistence_test.go
@@ -94,7 +94,6 @@ func (s *cassandraPersistenceSuite) TestPersistenceStartWorkflow() {
 		WorkflowTimeout:      20,
 		DecisionTimeoutValue: 13,
 		ExecutionContext:     nil,
-		LastFirstEventID:     common.FirstEventID,
 		NextEventID:          int64(3),
 		LastProcessedEvent:   0,
 		RangeID:              s.ShardInfo.RangeID - 1,

diff --git a/common/persistence/dataInterfaces.go b/common/persistence/dataInterfaces.go
@@ -360,7 +360,6 @@ type (
 		WorkflowTimeout             int32
 		DecisionTimeoutValue        int32
 		ExecutionContext            []byte
-		LastFirstEventID            int64
 		NextEventID                 int64
 		LastProcessedEvent          int64
 		TransferTasks               []Task

diff --git a/common/persistence/persistenceTestBase.go b/common/persistence/persistenceTestBase.go
@@ -213,7 +213,6 @@ func (s *TestBase) CreateWorkflowExecution(domainID string, workflowExecution wo
 		WorkflowTimeout:      wTimeout,
 		DecisionTimeoutValue: decisionTimeout,
 		ExecutionContext:     executionContext,
-		LastFirstEventID:     common.FirstEventID,
 		NextEventID:          nextEventID,
 		LastProcessedEvent:   lastProcessedEventID,
 		RangeID:              s.ShardInfo.RangeID,
@@ -270,7 +269,6 @@ func (s *TestBase) CreateWorkflowExecutionManyTasks(domainID string, workflowExe
 		Execution:                   workflowExecution,
 		TaskList:                    taskList,
 		ExecutionContext:            executionContext,
-		LastFirstEventID:            common.FirstEventID,
 		NextEventID:                 nextEventID,
 		LastProcessedEvent:          lastProcessedEventID,
 		TransferTasks:               transferTasks,
@@ -304,7 +302,6 @@ func (s *TestBase) CreateChildWorkflowExecution(domainID string, workflowExecuti
 		WorkflowTimeout:      wTimeout,
 		DecisionTimeoutValue: decisionTimeout,
 		ExecutionContext:     executionContext,
-		LastFirstEventID:     common.FirstEventID,
 		NextEventID:          nextEventID,
 		LastProcessedEvent:   lastProcessedEventID,
 		RangeID:              s.ShardInfo.RangeID,
@@ -387,7 +384,6 @@ func (s *TestBase) ContinueAsNewExecution(updatedInfo *WorkflowExecutionInfo, co
 			WorkflowTimeout:             updatedInfo.WorkflowTimeout,
 			DecisionTimeoutValue:        updatedInfo.DecisionTimeoutValue,
 			ExecutionContext:            nil,
-			LastFirstEventID:            common.FirstEventID,
 			NextEventID:                 nextEventID,
 			LastProcessedEvent:          common.EmptyEventID,
 			RangeID:                     s.ShardInfo.RangeID,