Add admin failover for managed domains #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Mar 30, 2020
| Name: "failover", | ||
| Aliases: []string{"fo"}, | ||
| Usage: "Failover domains with domain data IsManagedByCadence=true to target cluster", | ||
| Flags: []cli.Flag{ |
There was a problem hiding this comment.
It seems like this command should only be executed by cadence team. Should the command also takes in a security token and verify its content before actually execution?
Just an idea to explore. I understand this is not easy as the underlying domain failover command doesn't require security token.
There was a problem hiding this comment.
Good point. But security token on open sourced repo is merely support on server API.
Internally we will be protected by the auth feature.
yycptt
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add admin CLI command to failover managed domains
Why?
Currently domain failover is by design managed by cadence user. Some users dislike to failover themselves because they don't know how or when to failover.
By adding this managed failover support, cadence now have the ability to failover users domain on their behalf.
How did you test it?
Unit test.
Local test.
Will do staging test before release.
Potential risks
No risk.