Start cadence-server as pid 1 in the auto-setup container #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cadence-server in the auto-setup container was fixed so that it captures and handles the shutdown signals. This allows a quicker graceful exit. This was tested manually using docker compose to stop the auto-setup container and it exited faster without the hard kill which happens after a timeout.
|
|
|
I am unsure how long it takes the CLA signature to be approved as "signed". I signed it about 2 minutes before submitting this pull request. |
|
Thanks @jamisonbennett This looks good to me and I'll merge it once the test passes. |
yycptt
approved these changes
Apr 11, 2020
mkolodezny
pushed a commit
to mkolodezny/cadence
that referenced
this pull request
Apr 16, 2020
…rkflow#3175) The cadence-server in the auto-setup container was fixed so that it captures and handles the shutdown signals. This allows a quicker graceful exit. This was tested manually using docker compose to stop the auto-setup container and it exited faster without the hard kill which happens after a timeout. Co-authored-by: Liang Mei <[email protected]> Co-authored-by: Yichao Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cadence-server in the auto-setup container was fixed so that it
captures and handles the shutdown signals. This allows a quicker
graceful exit.
This was tested manually using docker compose to stop the auto-setup
container and it exited faster without the hard kill which happens
after a timeout.
What changed?
cadence-server runs as PID 1 in the auto-setup container
Why?
This allows a graceful and quick docker compose stop.
How did you test it?
I manually run the docker compose down and observed that it exited fast (it didn't delay for the 10-second hard kill).
Potential risks
None that I know of.