Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task list to CLI search workflow output #3183

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Add task list to CLI search workflow output #3183

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddeee98
Add task list to CLI search workflow output
mkolodezny Apr 9, 2020
f1fe5ea
Merge branch 'master' into tasklist
mkolodezny Apr 9, 2020
82a77bd
addressed comments
mkolodezny Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ require (
github.com/xwb1989/sqlparser v0.0.0-20180606152119-120387863bf2
go.opencensus.io v0.22.2 // indirect
go.uber.org/atomic v1.5.1
go.uber.org/cadence v0.9.1-0.20200128004345-b282629d5ba9
go.uber.org/cadence v0.11.3-0.20200408211929-2e8992a5ef2d
go.uber.org/fx v1.9.0
go.uber.org/multierr v1.3.0
go.uber.org/net/metrics v1.2.0 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,8 @@ go.uber.org/atomic v1.5.1 h1:rsqfU5vBkVknbhUGbAUwQKR2H4ItV8tjJ+6kJX4cxHM=
go.uber.org/atomic v1.5.1/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
go.uber.org/cadence v0.9.1-0.20200128004345-b282629d5ba9 h1:pmI3CA6StKZ56BfVQBdqjRbOScrgKY9zAQHw2QiYplg=
go.uber.org/cadence v0.9.1-0.20200128004345-b282629d5ba9/go.mod h1:VQIAZxvehjwln/xaRv1ghzcxo7TjCHEetZQkc8NlrvE=
go.uber.org/cadence v0.11.3-0.20200408211929-2e8992a5ef2d h1:65lxEqVKw7HDFojwOrc7CaIhaQQKQ2UJonogoI4nCKg=
go.uber.org/cadence v0.11.3-0.20200408211929-2e8992a5ef2d/go.mod h1:VQIAZxvehjwln/xaRv1ghzcxo7TjCHEetZQkc8NlrvE=
go.uber.org/dig v1.7.0 h1:E5/L92iQTNJTjfgJF2KgU+/JpMaiuvK2DHLBj0+kSZk=
go.uber.org/dig v1.7.0/go.mod h1:z+dSd2TP9Usi48jL8M3v63iSBVkiwtVyMKxMZYYauPg=
go.uber.org/fx v1.9.0 h1:7OAz8ucp35AU8eydejpYG7QrbE8rLKzGhHbZlJi5LYY=
Expand Down
7 changes: 3 additions & 4 deletions tools/cli/workflowCommands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,8 +987,8 @@ func createTableForListWorkflow(c *cli.Context, listAll bool, queryOpen bool) *t
table := tablewriter.NewWriter(os.Stdout)
table.SetBorder(false)
table.SetColumnSeparator("|")
header := []string{"Workflow Type", "Workflow ID", "Run ID", "Start Time", "Execution Time"}
headerColor := []tablewriter.Colors{tableHeaderBlue, tableHeaderBlue, tableHeaderBlue, tableHeaderBlue, tableHeaderBlue}
header := []string{"Workflow Type", "Workflow ID", "Run ID", "Task List", "Start Time", "Execution Time"}
headerColor := []tablewriter.Colors{tableHeaderBlue, tableHeaderBlue, tableHeaderBlue, tableHeaderBlue, tableHeaderBlue, tableHeaderBlue}
if !queryOpen {
header = append(header, "End Time")
headerColor = append(headerColor, tableHeaderBlue)
Expand Down Expand Up @@ -1086,8 +1086,7 @@ func appendWorkflowExecutionsToTable(
executionTime = convertTime(e.GetExecutionTime(), !printDateTime)
closeTime = convertTime(e.GetCloseTime(), !printDateTime)
}
// TODO add TaskList after client upgrade
row := []string{trimWorkflowType(e.Type.GetName()), e.Execution.GetWorkflowId(), e.Execution.GetRunId(), startTime, executionTime}
row := []string{trimWorkflowType(e.Type.GetName()), e.Execution.GetWorkflowId(), e.Execution.GetRunId(), *e.TaskList, startTime, executionTime}
mkolodezny marked this conversation as resolved.
Show resolved Hide resolved
if !queryOpen {
row = append(row, closeTime)
}
Expand Down