Support graceful failover in CLI #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Apr 19, 2020
tools/cli/domainUtils.go
Outdated
Comment on lines
169
to
172
| cli.StringFlag{ | ||
| Name: FlagFailoverTimeoutWithAlias, | ||
| Usage: "[Optional] Domain failover timeout in seconds. Default value: 60s", | ||
| }, |
There was a problem hiding this comment.
Probably IntFlag as the description says the value is in seconds? and default value "60" instead of "60s"?
tools/cli/domainCommands.go
Outdated
| if c.String(FlagFailoverType) == gracefulFailoverType { | ||
| failoverTimeout = &defaultFailoverTimeout | ||
| if c.IsSet(FlagFailoverTimeout) { | ||
| timeout := int32(c.Int(FlagFailoverTimeout)) |
There was a problem hiding this comment.
Timeout is defined as a StringFlag in the other file.
yycptt
approved these changes
Apr 27, 2020
vancexu
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add update domain operation set graceful failover timeout via CLI
Why?
Graceful failover will trigger from CLI.
How did you test it?
Local test
Potential risks
No risk as it is a pending feature