Fix NPE for task when global domain disabled #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
May 1, 2020
| @@ -2695,7 +2695,7 @@ func (e *historyEngineImpl) NotifyNewReplicationTasks( | |||
| tasks []persistence.Task, | |||
| ) { | |||
|
|
|||
| if len(tasks) > 0 { | |||
| if len(tasks) > 0 && e.replicatorProcessor != nil { | |||
There was a problem hiding this comment.
Should it be a bug is the processor is nil?
There was a problem hiding this comment.
My understanding is this processor always set when engine initializes
There was a problem hiding this comment.
only set when global domain is enabled. notify replication for non-global cluster is the bug, processor being nil is not a bug.
yux0
approved these changes
May 1, 2020
mkolodezny
pushed a commit
to mkolodezny/cadence
that referenced
this pull request
May 11, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix NPE
Why?
Came into this NPE while testing on staging.
This NPE happens when config clusterMetadata set enableGlobalDomain to false.
How did you test it?
staging test
Potential risks
no