Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing instructions #3242

Merged
merged 3 commits into from
May 19, 2020
Merged

Update contributing instructions #3242

merged 3 commits into from
May 19, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented May 7, 2020

What changed?

  • Remove "Dependency management" section (Cadance is no longer using godep for managing dependencies. Instead go mod is used which doesn't require any commands)
  • Update installation instructions of of cassandra, kafka, and zookeeper on OSX (you cannot use default zookeeper formula because it's not compatible with java that ships with OSX)

@sheerun sheerun force-pushed the update-contributing branch from ddf4612 to e7fa658 Compare May 7, 2020 21:29
meiliang86
meiliang86 reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@meiliang86 meiliang86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sheerun for fixing these. Left a comment. Otherwise looks good to me.

CONTRIBUTING.md
@@ -93,5 +93,5 @@ go test -v
# run single test
go test -v <path> -run <TestSuite> -testify.m <TestSpercificTaskName>
# example:
go test -v github.com/uber/cadence/common/persistence -run TestCassandraPersistenceSuite -testify.m TestPersistenceStartWorkflow
go test -v github.com/uber/cadence/common/persistence/persistence-tests -run TestVisibilitySamplingSuite -testify.m TestListClosedWorkflowExecutions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this unchanged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, but old one isn't working, there is no TestCassandraPersistenceSuite in this directory. Do you still want me to revert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meiliang86 ping

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 69.141% when pulling 2fec5d1 on sheerun:update-contributing into 3aab131 on uber:master.

@vancexu vancexu merged commit 6d2cfab into cadence-workflow:master May 19, 2020
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@sheerun @yux0
Update contributing instructions (cadence-workflow#3242)
5281c66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiliang86 meiliang86 meiliang86 left review comments

@vancexu vancexu vancexu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheerun @coveralls @vancexu @meiliang86