Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failover marker persistence #3274

Merged
merged 12 commits into from
May 27, 2020
Merged

Failover marker persistence #3274

merged 12 commits into from
May 27, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented May 21, 2020

What changed?
Provide persistence API to insert failover marker to the replication queue

Why?
To support graceful failover

How did you test it?
Integration test

Potential risks
N/A

@yux0 yux0 requested review from vancexu and yycptt May 21, 2020 17:20
@coveralls
Copy link

coveralls commented May 21, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 68.953% when pulling a15883e on failover_marker_replication_task into 4f3374f on master.

yycptt
yycptt reviewed May 22, 2020
View reviewed changes
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you also need another PR in the idl repo for the sqlblob change?

common/constants.go Outdated Show resolved Hide resolved
common/persistence/cassandra/cassandraPersistence.go Outdated Show resolved Hide resolved
common/persistence/cassandra/cassandraPersistenceUtil.go Outdated Show resolved Hide resolved
common/persistence/dataInterfaces.go Outdated Show resolved Hide resolved
common/persistence/sql/sqlExecutionManager.go Outdated Show resolved Hide resolved
common/persistence/sql/sqlExecutionManagerUtil.go Outdated Show resolved Hide resolved
common/persistence/cassandra/cassandraPersistence.go Show resolved Hide resolved
yycptt
yycptt approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check-in the idl submodule change before merging

@yux0 yux0 merged commit 99e0a09 into master May 27, 2020
@yux0 yux0 deleted the failover_marker_replication_task branch May 27, 2020 21:10
mkolodezny pushed a commit to mkolodezny/cadence that referenced this pull request May 29, 2020
@yux0 @mkolodezny
Failover marker persistence (cadence-workflow#3274)
825fe05
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
@yux0
Failover marker persistence (cadence-workflow#3274)
67866e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

@vancexu vancexu Awaiting requested review from vancexu

Assignees
No one assigned
Labels
graceful failover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yux0 @coveralls @yycptt