Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add processor to handle graceful failover timeout #3277

Merged
merged 16 commits into from
May 29, 2020
Merged

Add processor to handle graceful failover timeout #3277

merged 16 commits into from
May 29, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented May 22, 2020

What changed?

  1. Add a processor the watch domain failover endtime timeout
  2. Forbid domain failover to the same cluster

Why?
If graceful failover timed out, update domain to active.

How did you test it?
TBD

Potential risks
N/A

@yux0 yux0 requested review from vancexu and yycptt May 22, 2020 07:58
yycptt
yycptt reviewed May 22, 2020
View reviewed changes
service/frontend/service.go Outdated Show resolved Hide resolved
service/worker/service.go Outdated Show resolved Hide resolved
common/domain/failover_processor.go Outdated Show resolved Hide resolved
common/domain/failover_processor.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 28, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 68.085% when pulling 49063e8 on handle_failover_timeout into 950591c on master.

yycptt
yycptt reviewed May 29, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
common/service/dynamicconfig/constants.go Outdated Show resolved Hide resolved
common/domain/failover_watcher.go Show resolved Hide resolved
common/domain/failover_watcher.go Outdated Show resolved Hide resolved
@yux0 yux0 merged commit 514bc73 into master May 29, 2020
@yux0 yux0 deleted the handle_failover_timeout branch May 29, 2020 19:52
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
@yux0
Add processor to handle graceful failover timeout (cadence-workflow#3277
82dfbe1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

@vancexu vancexu Awaiting requested review from vancexu

Assignees
No one assigned
Labels
graceful failover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yux0 @coveralls @yycptt