Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer queue processor base v2 #3306

Merged
merged 14 commits into from
Jun 5, 2020

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 2, 2020

What changed?

  • Rewrite timer queue processor base with multi-cursor queue components
  • Create util functions for common parts in timer and transfer queue processor base
  • Use struct instead of pointer as timer/transfer task key
  • Move timerGate to queue package

Why?
Part of multi-cursor queue implementation

How did you test it?
Unite test

Potential risks
N/A, implementation not wired up yet

@yycptt yycptt requested review from yux0 and emrahs June 2, 2020 18:24
@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.2%) to 67.831% when pulling 479a070 on yycptt:timer-queue-processor-base-v2 into a9e4715 on uber:master.

@yycptt yycptt merged commit 9ffa5e4 into cadence-workflow:master Jun 5, 2020
@yycptt yycptt deleted the timer-queue-processor-base-v2 branch June 5, 2020 21:37
emrahs pushed a commit that referenced this pull request Aug 18, 2020
* Rewrite timer queue processor base with multi-cursor queue components
* Create util functions for common parts in timer and transfer queue processor base
* Use struct instead of pointer as timer/transfer task key
* Move timerGate to queue package
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
* Rewrite timer queue processor base with multi-cursor queue components
* Create util functions for common parts in timer and transfer queue processor base
* Use struct instead of pointer as timer/transfer task key
* Move timerGate to queue package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants