Add header options for starting workflow via CLI (#2862) #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not possible to set header values via CLI when starting a workflow. This change exposes three new optional parameters for starting a workflow: - header_key - header_value - header_file They allow setting header values in JSON format which are propogated via workflow context. Values can be provides either directly or with a file. If multiple keys and values are used, they separated by a space. Count of keys and values must be equal, otherwise error is returned.
vancexu
approved these changes
Jun 15, 2020
| @@ -311,6 +316,35 @@ func processSearchAttr(c *cli.Context) map[string][]byte { | |||
| return fields | |||
| } | |||
|
|
|||
| func processHeader(c *cli.Context) map[string][]byte { | |||
There was a problem hiding this comment.
This looks similar to processMemo, can we try refactor to reduce duplicates?
There was a problem hiding this comment.
Sure, refactored them.
vytautas-karpavicius
changed the title
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
…) (cadence-workflow#3341) It was not possible to set header values via CLI when starting a workflow. This change exposes three new optional parameters for starting a workflow: - header_key - header_value - header_file They allow setting header values in JSON format which are propagated via workflow context. Values can be provides either directly or with a file. If multiple keys and values are used, they separated by a space. Count of keys and values must be equal, otherwise error is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This change exposes three new optional parameters for starting a workflow:
They allow setting header values in JSON format which are propogated
via workflow context. Values can be provides either directly or with a
file. If multiple keys and values are used, they separated by a space.
Count of keys and values must be equal, otherwise error is returned.
Why?
It was not possible to set header values via CLI when starting a workflow.
How did you test it?
Tested locally with:
Verified that headers were set on local server:
Potential risks