Update replication ack level if response has no task #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jun 23, 2020
| metrics.ReplicatorQueueProcessorScope, | ||
| metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())), |
There was a problem hiding this comment.
We may need to check gc and cpu usage for this shardID tag. Not sure if it will cause the same thing as adding domain tag to task processing.
There was a problem hiding this comment.
I don't think replication is this time-sensitive. But we can verify
yux0
added a commit
that referenced
this pull request
Jun 23, 2020
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update replication ack level if response has no task
Why?
if the workflow passed the retention day and got delete, the replication task ack level should be updated.
How did you test it?
Unit test and local tests
Potential risks
N/A