Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting metrics if DLQ is not empty #3389

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Emitting metrics if DLQ is not empty #3389

merged 6 commits into from
Jul 16, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jul 15, 2020

What changed?
Adding a loop to emit metrics if DLQ is not empty

Why?
The approach to calculating the delta of max DLQ message ID and acked DLQ message ID is not practical due to the metrics measure window. So we have to query and emit these metrics.

How did you test it?
integration test

Potential risks

@yux0 yux0 requested review from vancexu and emrahs July 15, 2020 19:23
@coveralls
Copy link

coveralls commented Jul 15, 2020

Coverage Status

Coverage increased (+0.08%) to 67.13% when pulling b615cef on dlq_empty into de1ad6d on master.

@yux0 yux0 merged commit a1aad87 into master Jul 16, 2020
@yux0 yux0 deleted the dlq_empty branch July 16, 2020 17:13
yux0 added a commit that referenced this pull request Jul 16, 2020
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants