show timers distribution on a histogram #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/cli/adminTimers.go
Outdated
| h.Add(t.VisibilityTimestamp.Format(hp.timeFormat)) | ||
| } | ||
|
|
||
| if err := h.Print(hp.ctx.Int(FlagShardMultiplier)); err != nil { |
There was a problem hiding this comment.
nit: maybe just return h.Print(hp.ctx.Int(FlagShardMultiplier)) the if does not add anything here.
There was a problem hiding this comment.
good catch!
tools/cli/histogram.go
Outdated
| counters []*counter | ||
| } | ||
|
|
||
| func NewHistorgram() *Histogram { |
There was a problem hiding this comment.
s/NewHistorgram/NewHistogram
tools/cli/histogram.go
Outdated
| if len(key) > len(h.maxKey) { | ||
| h.maxKey = key | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: remove empty line
tools/cli/histogram.go
Outdated
| func (h *Histogram) Add(key string) { | ||
| var found bool | ||
| for _, c := range h.counters { | ||
|
|
There was a problem hiding this comment.
nit: remove empty line
tools/cli/adminTimers.go
Outdated
| type Printer interface { | ||
| Print(timers []*persistence.TimerTaskInfo) error | ||
| } | ||
| type TimerPrinter struct { |
There was a problem hiding this comment.
Can we call it something else? Initial glance suggests that it might implement Printer interface. While it is an aggregate structure of both loader and printer.
andrewjdawson2016
approved these changes
Jul 29, 2020
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
* show timers distribution on a histogram * Add license header * add convenient time bucket option * address comments * rename raw printer to json printer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks