Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for failover #3415

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Bug fixes for failover #3415

merged 3 commits into from
Jul 31, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jul 29, 2020

What changed?
Bug fixes for failover

Why?

  1. compare failover version with a value
  2. assign failover end time with the new pointer
  3. remove the duplicated method
  4. Add active cluster field in DomainNotActive error
  5. Fix misuse failover notification version to failover verison

How did you test it?
Local tests

Potential risks
N/A

@yux0 yux0 requested a review from yycptt July 29, 2020 00:25
service/history/shard/context.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 66.979% when pulling 4afb8de on failover_fixes into 6aca638 on master.

@yux0 yux0 merged commit 121ef1e into master Jul 31, 2020
@yux0 yux0 deleted the failover_fixes branch July 31, 2020 11:21
yux0 added a commit that referenced this pull request Jul 31, 2020
yux0 added a commit that referenced this pull request Jul 31, 2020
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants