Differentiate metrics for domainTagged metrics and task operation metrics #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish531213
force-pushed
the
aanish/emit-domain-metrics
branch
from
3995fdd to
5c4281e
Compare
yycptt
suggested changes
Aug 21, 2020
There was a problem hiding this comment.
Please take a look at how metricRollupName works: https://github.com/uber/cadence/blob/master/common/metrics/defs.go#L2098
It can make code much cleaner as we only need to call IncCounter() or RecordTimer() once, instead of copy-pasting code.
yycptt
reviewed
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Right now when metrics is emitted with domain tag, our current dashboard and alerts will look at the metrics (p99/mean) only for the one domain due to maxSeries. So, in order to solve this problem, I introduced emitting both domainTagged metrics and operation metrics separately with different metics name. This change is only made for new task processing.
Why?
How did you test it?
Haven't tested it yet.
Potential risks
No risk.