Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e integration tests for Postgres and remove 2dc runs #3532

Merged
merged 15 commits into from
Sep 22, 2020

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Sep 21, 2020

What changed?
Adding postgres to run with integration test suits

Why?
Follow up to a conversation in #3488 (comment)

How did you test it?
It's adding tests

Potential risks
No

Local run succeeded:

docker-compose -f docker/buildkite/docker-compose-local.yml run integration-test-postgres
...
...
"service": "cadence-matching", "logging-call-at": "service.go:115"}
--- PASS: TestSizeLimitIntegrationSuite (14.23s)
    --- PASS: TestSizeLimitIntegrationSuite/TestTerminateWorkflowCausedBySizeLimit (2.44s)
PASS
coverage: 29.0% of statements in github.com/uber/cadence/common/..., github.com/uber/cadence/service/..., github.com/uber/cadence/client/..., github.com/uber/cadence/tools/...
ok  	github.com/uber/cadence/host	546.843s	coverage: 29.0% of statements in github.com/uber/cadence/common/..., github.com/uber/cadence/service/..., github.com/uber/cadence/client/..., github.com/uber/cadence/tools/...
1539.65user 518.08system 10:40.22elapsed 321%CPU (0avgtext+0avgdata 1528492maxresident)
136720inputs+1913456outputs (50major+10853577minor)pagefaults 0swaps

@longquanzheng longquanzheng changed the title WIP: Add e2e integration tests for Postgres Add e2e integration tests for Postgres Sep 22, 2020
@longquanzheng
Copy link
Contributor Author

@yux0 since you are removing 2DC code, should I just remove all the 2dc stuff here? so that it will save you some effort to do it in another PR.

@@ -8,10 +8,6 @@ go get github.com/dmetzgar/goveralls
# download cover files from all the tests
mkdir -p build/coverage
buildkite-agent artifact download "build/coverage/unit_cover.out" . --step ":golang: unit test" --build "$BUILDKITE_BUILD_ID"
buildkite-agent artifact download "build/coverage/integ_cassandra_cover.out" . --step ":golang: integration test with cassandra" --build "$BUILDKITE_BUILD_ID"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are those useless? I assume we don't generate code coverage in integration tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I believe so.
And if you look at the list, it doesn't take ndc into account. I don't have permission, would you have help me kick off a run to see how the coverage would change?

@yux0
Copy link
Contributor

yux0 commented Sep 22, 2020

@yux0 since you are removing 2DC code, should I just remove all the 2dc stuff here? so that it will save you some effort to do it in another PR.

Thanks. It would be great

Copy link
Contributor

@andrewjdawson2016 andrewjdawson2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @longquanzheng

@longquanzheng
Copy link
Contributor Author

@yux0 @andrewjdawson2016 because I don't have permission :( can you help trigger a buildkite when reviewing it?

@longquanzheng longquanzheng changed the title Add e2e integration tests for Postgres Add e2e integration tests for Postgres and remove 2dc runs Sep 22, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 68.008% when pulling 30b646b on longquanzheng:e2e-postgres into 8bd97e5 on uber:master.

@longquanzheng longquanzheng merged commit 68ff306 into cadence-workflow:master Sep 22, 2020
@longquanzheng longquanzheng deleted the e2e-postgres branch April 6, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants