Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scanner] add generic shard scanner #3638

Merged

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Shard scanner is a generic shard scanner.

To use shard scanner you need to provide:

  • invariant manager - to set-up check and fix actions defined by scanner user.
  • iterator - shard scanner uses iterator interface to iterate over entities.
  • config resolver (optional) - scanner users can have their own custom dynamic configs. Config values are recorded for better determinism.

Why?
This shard scanner helps to reduce boilerplate when introducing new types of scanners, no need to reimplement/duplicate common logic.

How did you test it?
Unit tests.

Potential risks
None, this is noop change

@coveralls
Copy link

coveralls commented Oct 13, 2020

Coverage Status

Coverage increased (+0.08%) to 59.52% when pulling 777a50b on mantas-sidlauskas:shard_scanner into 8055ae8 on uber:master.

@mantas-sidlauskas mantas-sidlauskas merged commit 6a1c6a0 into cadence-workflow:master Oct 28, 2020
@mantas-sidlauskas mantas-sidlauskas deleted the shard_scanner branch October 28, 2020 08:20
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants