Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replicator internal types #3660

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Replicator internal types #3660

merged 2 commits into from
Oct 15, 2020

Conversation

andrewjdawson2016
Copy link
Contributor

This diff adds replicator internal types to the set of generated types. In order to this a few changes had to be made

  • Handling all map types now instead of just string maps
  • Handling fields which are declared in other packages correctly keeping track of current symbols in addition to global symbols.

@github-actions github-actions bot force-pushed the replicator_internal_types branch from 19e357e to 8e3f942 Compare October 15, 2020 22:09
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 61.949% when pulling 8e3f942 on replicator_internal_types into 3ea959f on master.

@andrewjdawson2016 andrewjdawson2016 merged commit 630357c into master Oct 15, 2020
@andrewjdawson2016 andrewjdawson2016 deleted the replicator_internal_types branch October 15, 2020 22:31
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
@andrewjdawson2016
Replicator internal types (cadence-workflow#3660)
a7aec76
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@andrewjdawson2016 @yux0
Replicator internal types (cadence-workflow#3660)
046289f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anish531213 anish531213 anish531213 approved these changes

@vytautas-karpavicius vytautas-karpavicius Awaiting requested review from vytautas-karpavicius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewjdawson2016 @coveralls @anish531213