Fix lint warnings for generated internal types #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjdawson2016
approved these changes
Oct 28, 2020
mkolodezny
reviewed
Nov 30, 2020
| @@ -2898,8 +2898,7 @@ func FromHistoryRespondDecisionTaskCompletedResponse(t *types.HistoryRespondDeci | |||
| return nil | |||
| } | |||
| return &history.RespondDecisionTaskCompletedResponse{ | |||
| StartedResponse: FromRecordDecisionTaskStartedResponse(t.StartedResponse), | |||
| ActivitiesToDispatchLocally: FromActivityLocalDispatchInfoMap(t.ActivitiesToDispatchLocally), | |||
There was a problem hiding this comment.
please revert the ActivitiesToDispatchLocally back
mkolodezny
reviewed
Nov 30, 2020
| @@ -2909,8 +2908,7 @@ func ToHistoryRespondDecisionTaskCompletedResponse(t *history.RespondDecisionTas | |||
| return nil | |||
| } | |||
| return &types.HistoryRespondDecisionTaskCompletedResponse{ | |||
| StartedResponse: ToRecordDecisionTaskStartedResponse(t.StartedResponse), | |||
| ActivitiesToDispatchLocally: ToActivityLocalDispatchInfoMap(t.ActivitiesToDispatchLocally), | |||
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Andrew Dawson <[email protected]>
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Co-authored-by: Andrew Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Linter was complaining
How did you test it?
Potential risks