Thrift clients #3695
Merged
Thrift clients #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Oct 28, 2020
|
|
||
| // Client is the interface exposed by admin service client | ||
| type Client interface { | ||
| adminserviceclient.Interface | ||
| AddSearchAttribute(context.Context, *admin.AddSearchAttributeRequest, ...yarpc.CallOption) error |
There was a problem hiding this comment.
qq: why we will not use the embedded thrift interface?
There was a problem hiding this comment.
This was changed on purpose so that we can change method signatures to accept and return internal types instead of thrift counterparts. Thrift types will be only be used in thrift clients and handlers. These changes will come with upcoming PRs.
yux0
approved these changes
Oct 30, 2020
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
This is prep-work for introducing internal application types. For now this change simply adds no-op thrift wrappers. Later on they will become a place for internal types to thrift conversion. Explicitly listed Client interfaces will operate on on internal types and only at the thriftClient they will be converted to thrift counterparts. - Explicitly listed Client interfaces instead of embedding thrift client interfaces. - Created thriftClient wrappers. Currently they only forward the request as is.
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
This is prep-work for introducing internal application types. For now this change simply adds no-op thrift wrappers. Later on they will become a place for internal types to thrift conversion. Explicitly listed Client interfaces will operate on on internal types and only at the thriftClient they will be converted to thrift counterparts. - Explicitly listed Client interfaces instead of embedding thrift client interfaces. - Created thriftClient wrappers. Currently they only forward the request as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Clientinterfaces instead of embedding thrift client interfaces.thriftClientwrappers. Currently they only forward the request as is.Why?
This is prep-work for introducing internal application types. For now this change simply adds no-op thrift wrappers. Later on they will become a place for internal types to thrift conversion. Explicitly listed
Clientinterfaces will operate on on internal types and only at the thriftClient they will be converted to thrift counterparts.How did you test it?
Potential risks