Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retry policy for operations in task processing #3765

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Nov 17, 2020

What changed?
Change retry policy in task processing from 30s expiration interval to a max attempt of 3.

Why?
Retry 30s will block other tasks from being processed

How did you test it?
Unit test

Potential risks
N/A

@yycptt yycptt requested a review from yux0 November 17, 2020 21:40
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 60.117% when pulling d40b096 on yycptt:improve-task-retry into 94e61d8 on uber:master.

@yycptt yycptt merged commit 005d7e8 into cadence-workflow:master Nov 18, 2020
@yycptt yycptt deleted the improve-task-retry branch November 18, 2020 00:36
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants