Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch visibility related types to internal #3770

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Switch visibility related types to internal types and propagate changes upwards until handlers.

Why?
To propagate internal types throughout Cadence codebase.

How did you test it?

Potential risks

@coveralls
Copy link

coveralls commented Nov 18, 2020

Coverage Status

Coverage increased (+0.1%) to 60.273% when pulling 136c29f on vytautas-karpavicius:visibility-internal-types into 32b167b on uber:master.

@vytautas-karpavicius vytautas-karpavicius requested a review from a team November 18, 2020 18:04
Copy link
Contributor

@anish531213 anish531213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vytautas-karpavicius vytautas-karpavicius merged commit b0316fa into cadence-workflow:master Nov 19, 2020
@vytautas-karpavicius vytautas-karpavicius deleted the visibility-internal-types branch November 19, 2020 09:31
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants