Add admin CLI scan command for unsupported workflows #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Dec 3, 2020
yycptt
approved these changes
Dec 4, 2020
|
|
||
| defer outputFile.Close() | ||
| for i := startShardID; i <= endShardID; i++ { | ||
| listExecutionsByShardID(c, i, rps, outputFile) |
There was a problem hiding this comment.
I feel like if the scan is done in only one goroutine, it will take a long time to finish and the rps limit is kind of useless and will never be reached. But no strong opinion on that.
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add admin CLI scan command for unsupported workflows
Why?
0.16 release cleans up the 2dc workflow code path. This 2dc workflow will not be supported after release 0.16.
How did you test it?
Cassandra local test
MySQL local test
TODO: Postgres test
Potential risks
The command may take a long time to finish with large data set.