TimerQueueProcessor to scan DB for exisiting timers on init #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimerQueueProcessor used to setup a very long timer on initialization to notify processor for doing a DB scan. This becomes problematic when you have existing timers and shard restarts. Now after initialization of shard there is no trigger for the processor to perform a DB scan. It now has to wait for a trigger from outside to perform the first scan so it can start operating as usual. This change removes the infite timer on initialize to perform first scan immediately to check for existing timers. Also some code cleanup and removing some unnecessary code. fixes cadence-workflow#454
|
Changes Unknown when pulling 4a215b7 on samarabbas:timer-queue-processor-stuck-fix into ** on uber:master**. |
venkat1109
approved these changes
Dec 9, 2017
| timer *time.Timer // timer used to wake us up when the next message is ready to deliver | ||
| gateC chan struct{} | ||
| closeC chan struct{} | ||
| tNext, tNow int64 // time (in 'UnixNano' units) for next, (last) now and end |
There was a problem hiding this comment.
fix comment to remove "end" (or) better yet, remove the comment and rename the vars to suffix with Nanos
|
Changes Unknown when pulling 5e7b8e9 on samarabbas:timer-queue-processor-stuck-fix into ** on uber:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimerQueueProcessor used to setup a very long timer on initialization to
notify processor for doing a DB scan. This becomes problematic when you
have existing timers and shard restarts. Now after initialization of
shard there is no trigger for the processor to perform a DB scan. It
now has to wait for a trigger from outside to perform the first scan so
it can start operating as usual.
This change removes the infite timer on initialize to perform first scan
immediately to check for existing timers.
Also some code cleanup and removing some unnecessary code.
fixes #454