Fix workflow replication for reset workflow #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Oct 3, 2023
shijiesheng
approved these changes
Oct 11, 2023
Shaddoll
force-pushed
the
fix-ndc-reset
branch
from
f82a51a
to
04545a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix workflow replication for reset workflow
Why?
Currently if we failover a domain with failover_version equal to 0 and reset a workflow, the replication of that reset workflow can potentially fail.
How did you test it?
new unit test
Potential risks
Release notes
Documentation Changes