Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MigrationChecker interface to expose migration CLI #5424

Merged
merged 4 commits into from
Oct 19, 2023
Merged

MigrationChecker interface to expose migration CLI #5424

merged 4 commits into from
Oct 19, 2023

Conversation

abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented Oct 17, 2023 •
edited
Loading

In this PR, we've made several changes to the code:

  • Added DomainMigrationChecker interface to expose the validation methods outside for Prodfix check/fix.
  • Updated the domainMigrationCLIImpl struct to include client dependencies.
  • Added validation checks for domain metadata, workflow status, search attributes, and dynamic configurations.

@abhishekj720 abhishekj720 changed the title added interface to expose migration CLI outside MigrationChecker interface to expose migration CLI Oct 17, 2023
shijiesheng
shijiesheng approved these changes Oct 17, 2023
View reviewed changes
tools/cli/domainMigrationCommand.go Outdated Show resolved Hide resolved
@abhishekj720 abhishekj720 merged commit 7b6cf61 into cadence-workflow:master Oct 19, 2023
@abhishekj720 abhishekj720 deleted the metadata-fix branch October 19, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shijiesheng shijiesheng shijiesheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekj720 @shijiesheng