Bugfix: add non-empty custom scanner config to fix timer fixer #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally broken in cadence-workflow#5361 - this timer-fixer uses the shared fixer workflow, which now expects non-empty config about what invariants are enabled. Since that'll help make this clearer / less "enable by default"-prone for future timer-invariants, I've just added a static non-empty config.
davidporter-id-au
approved these changes
Nov 6, 2023
Groxx
added a commit
that referenced
this pull request
Nov 15, 2023
#5361 unfortunately broke timer-fixers, as the shared workflow requires a non-empty "enabled" list and none was provided in that PR. #5433 restores that functionality. --- Arguably `v1.2.5` could be retracted, as it introduces a potentially-problematic bug. Since this fixer is disabled by default, we're going to skip doing that: we would have to publish `v1.2.6` to put the retraction into effect, and anyone updating that rapidly will not have much down-time. Plus the fixer is not required for correct behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally broken in #5361 - this timer-fixer uses the shared
fixer workflow, which now expects non-empty config about what invariants
are enabled.
Since that'll help make this clearer / less "enable by default"-prone for
future timer-invariants, I've just added a static non-empty config.