-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log user query param #5437
Add log user query param #5437
Conversation
…not visibility triple manager
Is there any reason we parse the query here instead of doing it in the workflow? I am asking because if we moved to the workflow code, it will be much easier here to log and export the queries, we don't need to remove the code after migration, etc. |
You are right. We can put it in the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changed?
Add log user query param
Why?
for Pinot/ES comparator usage
How did you test it?
unit test, integration test
Potential risks
Release notes
Documentation Changes