Add an "all results" query to scanner/fixer workflows #5470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds an
all_results
query to both scanner and fixer workflows, to retrieve all (non-empty) results in one operation. This makes it easier to find all failures and all output filenames, without having to repeatedly query in varying ways.Why
Currently, getting all output filenames from these workflows is an exercise in frustration.
You can:
shard_corrupt_keys
to get all shards with corruptions (no data on fails, etc)shard_report
to get a single shard's corruptions, errors, skips, control-flow failuresBut unfortunately:
the end result goes into "failures". this is true for scans too, corrupt + fail == fail.
Many small bits of friction make trying to bulk-analyze this system incredibly painful.
While we do need to just rewrite the whole thing to be less... like it is... we can at least expose this bulk info quite easily in a new query.