Updated the unit test for BlobstoreIterator into a table format #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agautam478
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Converted the already present test that was using Testing suite into and independent table test.
pItrvariable is an iterator created by fetcher.ConcreteExecutionIterator, which iterates over concrete executions.NewBlobstoreWriteris used to create a writer for the blobstore, and executions are added to this writer.NewBlobstoreIteratoris then used to iterate over the written blobs, and assertions are made to ensure the data integrity.Why?
These changes were made as a part of our initiative to increase the code coverage and also to maintain consistency with it's sister
BlobstoreWritertest.How did you test it?
yes. Tested locally.
Potential risks
NA
Release notes
NA
Documentation Changes
NA