Improve logs/metrics of HandleDecisionTaskCompleted #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
davidporter-id-au
approved these changes
Dec 19, 2023
taylanisikdemir
force-pushed
the
taylan/resp_decision_logs_metrics
branch
2 times, most recently
from
c3b2c8e
to
3eab9d9
Compare
taylanisikdemir
force-pushed
the
taylan/resp_decision_logs_metrics
branch
from
3eab9d9
to
7152058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
history/decision/handler's HandleDecisionTaskCompleted is doing a lot of things but with limited visibility so improving it with following changes:
Why?
Improve debugging
How did you test it?
make test