Add persistence serialization unit tests #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
serialization-units
branch
from
afc5f02
to
8fd4499
Compare
|
Coverage increase from 48.5% to 85.9% 
|
taylanisikdemir
approved these changes
Dec 20, 2023
3vilhamster
force-pushed
the
serialization-units
branch
from
57d34ae
to
5a14b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added tests for serialization logic in persistence layer.
On the side, found that IsCron flag was not set when extracting result from sql level.
Also, removed empty protoDecoder and protoEncoder. No methods implemented, we should reintroduce them once we will have plans for the implementation.
Why?
To improve test coverage.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes