Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for sql domain store #5508

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

Shaddoll
Copy link
Member

What changed?

  • Add unit test for mysql configstore
  • Split sql statements into a different file

Why?
To improve code quality

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Though, I would like to have error cases separated from non-error. That makes test setup easier and makes easier to reason on missing test coverage.
Something like:

TestGetMetadataSuccess()

TestGetMetadataFailures()

@Shaddoll Shaddoll enabled auto-merge (squash) December 20, 2023 17:08
@Shaddoll Shaddoll merged commit 053b8a8 into cadence-workflow:master Dec 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants