Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for AwaitWaitGroup #5512

Conversation

arzonus
Copy link
Contributor

@arzonus arzonus commented Dec 20, 2023

What changed?
Addition of unit tests

Why?
AwaitWaitGroup didn't have test

How did you test it?
unit tests passed

Potential risks

Release notes

Documentation Changes

@arzonus arzonus enabled auto-merge (squash) December 20, 2023 14:12
Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though having a common function with time.After is a sad thing.

@arzonus arzonus merged commit 636b5d0 into cadence-workflow:master Dec 20, 2023
16 checks passed
@arzonus arzonus deleted the CDNC-6460-add-tests-for-await-wait-group branch December 20, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants