Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit-test for matching:newTaskListID #5513

Merged

Conversation

dkrotx
Copy link
Member

@dkrotx dkrotx commented Dec 20, 2023

Bumping coverage of tasklist.go to 100%

  • unit-test

increase code-coverage

make test

Potential risks

Release notes

Documentation Changes

@dkrotx dkrotx force-pushed the matching-tasklist-test-coverage branch from 80caf3d to 530338e Compare December 20, 2023 18:06
@dkrotx dkrotx enabled auto-merge (squash) December 20, 2023 18:07
@dkrotx dkrotx force-pushed the matching-tasklist-test-coverage branch from a837721 to 65ea2cf Compare February 26, 2024 16:34
service/matching/tasklist_test.go Show resolved Hide resolved
Bumping coverage of tasklist.go to 100%
@dkrotx dkrotx force-pushed the matching-tasklist-test-coverage branch from 65ea2cf to 3e68cc9 Compare February 26, 2024 17:27
@dkrotx dkrotx dismissed agautam478’s stale review February 26, 2024 17:30

just updated the diff with fmt

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018de674-b6b4-4841-b6c5-ec283d95cf1b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 85 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.05%) to 62.952%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/util.go 2 91.69%
common/persistence/statsComputer.go 3 96.07%
service/matching/taskListManager.go 3 79.7%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
service/history/task/transfer_standby_task_executor.go 4 87.42%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go 12 20.93%
common/persistence/sql/workflowStateMaps.go 19 81.25%
service/history/execution/mutable_state_task_refresher.go 31 57.28%
Totals Coverage Status
Change from base Build 018dd83e-52b0-4905-a381-bf89981dace4: 0.05%
Covered Lines: 93028
Relevant Lines: 147777

💛 - Coveralls

@dkrotx dkrotx merged commit 581eb07 into cadence-workflow:master Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants