Test for rate limited wrappers around persistence clients #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
rate-limiter-tests
branch
from
9991d16
to
37f2525
Compare
Groxx
reviewed
Dec 21, 2023
Comment on lines
+23
to
+29
| //go:generate gowrap gen -g -p . -i ConfigStoreManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/configstore.go | ||
| //go:generate gowrap gen -g -p . -i DomainManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/domain.go | ||
| //go:generate gowrap gen -g -p . -i HistoryManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/history.go | ||
| //go:generate gowrap gen -g -p . -i ExecutionManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/execution.go | ||
| //go:generate gowrap gen -g -p . -i QueueManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/queue.go | ||
| //go:generate gowrap gen -g -p . -i TaskManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/task.go | ||
| //go:generate gowrap gen -g -p . -i ShardManager -t ./ratelimited/template/ratelimited.tmpl -o ratelimited/shard.go |
There was a problem hiding this comment.
yaaay! very glad to see a bunch of these get standardized, manual upkeep for this kind of thing is pure waste and risk. thanks!
taylanisikdemir
approved these changes
Dec 21, 2023
3vilhamster
force-pushed
the
rate-limiter-tests
branch
from
37f2525
to
f637a6b
Compare
3vilhamster
force-pushed
the
rate-limiter-tests
branch
from
f637a6b
to
fe38164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Improving test coverage for rate limiter wrappers of persistence clients.
Persistence layer exposes rate limiter wrappers around all of the provided interfaces.
These wrappers do not have special logic, so now they are generated by template. I've added tests for existing clients to ensure behaviour. Though, it could be deleted later on.
Test coverage now is on 95%.
Why?
Improving test coverage and code readability.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes