Add unit tests for thrift mappers #5542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
Shaddoll
approved these changes
Dec 27, 2023
taylanisikdemir
force-pushed
the
taylan/thrift_mapper_tests
branch
from
cad7256
to
e7ba8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
There was a thrift-tests folder with a few test cases. This folder was created as a workaround to avoid cyclic imports. Got rid of cyclic import by hardcoding a few things in testdata and moved the tests to correct package
common/types/mapper/thrift.Also added bunch of new tests cases with help of copilot.
Some call outs:
ParentWorkflowDomainIDfield. Had to apply a workaround in test payload comparisons to ignore this field.ContinueAsNewWorkflowExecutionDecisionAttributes.JitterStartSecondswas not mapped. Updated corresponding from/to mapper functions to populate/use it.Why?
Improve coverage
How did you test it?
unit tests.