Add unit tests for ValidateLongPollXXX #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lContextTimeoutIsSet
arzonus
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Dec 27, 2023
| @@ -1043,3 +1044,64 @@ func TestDeserializeSearchAttributeValue_Error(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestValidateLongPollContextTimeout(t *testing.T) { | |||
There was a problem hiding this comment.
This could be turned into table formatted test to reduce repeated test body code.
tests := []struct {
desc string
loggerFn func() log.MockLogger
timeout time.Duration
wantErr error
} {
...
}
There was a problem hiding this comment.
Yeah, it can be turned, but I am not sure the readability will be improved. Also, 2 of 4 cases check errors, so it requires us to write conditionals. I'd like to leave it as it is.
…tests_for_ValidateLongPollXXX # Conflicts: # common/util_test.go
…tests_for_ValidateLongPollXXX # Conflicts: # common/util_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Unit tests for ValidateLongPollContextTimeout and ValidateLongPollContextTimeoutIsSet have been added
Why?
ValidateLongPollContextTimeout and ValidateLongPollContextTimeoutIsSet were not covered by unit tests
How did you test it?
Unit tests are passed
Potential risks
Release notes
Documentation Changes