Add logs to debug timer tasks #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Jan 5, 2024
| @@ -1919,6 +1919,9 @@ const ( | |||
| // Value type: Bool | |||
| // Default value: true | |||
| EnableShardIDMetrics | |||
|
|
|||
There was a problem hiding this comment.
can you add the comments as the other constants have? it's kind of redundant with below definition but better to be consistent until we come up with a better structure to define these dynamicconfigs
There was a problem hiding this comment.
Actually, I'm planning to remove those comments.
| tag.TaskID(task.TaskID), | ||
| tag.WorkflowTimerID(timerInfo.TimerID), | ||
| tag.WorkflowScheduleID(timerInfo.StartedID), | ||
| tag.WorkflowNextEventID(mutableState.GetNextEventID()), |
There was a problem hiding this comment.
do you think it would help to include details from timerSequenceID?
There was a problem hiding this comment.
timerSequenceID.EventID is the same as timerInfo.StartedID
Comment on lines
+220
to
+227
| tag.WorkflowDomainID(task.DomainID), | ||
| tag.WorkflowID(task.WorkflowID), | ||
| tag.WorkflowRunID(task.RunID), | ||
| tag.TaskType(task.TaskType), | ||
| tag.TaskID(task.TaskID), | ||
| tag.WorkflowTimerID(timerInfo.TimerID), | ||
| tag.WorkflowScheduleID(timerInfo.StartedID), | ||
| tag.WorkflowNextEventID(mutableState.GetNextEventID()), |
There was a problem hiding this comment.
you can define the tags at line 206 above if/else so they don't go out of sync between info and debug calls in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add logs to debug timer tasks
Why?
To improve observability for debugging duplicate timer issues
How did you test it?
Potential risks
Release notes
Documentation Changes